sky/examples/file-browser.sky - Issue 696373003: Don't GC message pipes that have an in-flight request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/file-browser.sky

Issue 696373003: Don't GC message pipes that have an in-flight request (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/examples/file-browser.sky

diff --git a/sky/examples/file-browser.sky b/sky/examples/file-browser.sky

index 6d02f84839cf6ae7de2171625a7ade9a99729370..43c1267b30cfd512f4e3040c2acb175cdd4dcf3e 100644

--- a/sky/examples/file-browser.sky

+++ b/sky/examples/file-browser.sky

@@ -28,7 +28,7 @@ SkyElement({

directories: [],

attached: function() {

this.url = this.ownerDocument.URL;

- var xhr = this.xhr_ = new XMLHttpRequest();

+ var xhr = new XMLHttpRequest();

xhr.open('GET', this.url + '?format=json');

xhr.onload = (function() {

var listing = JSON.parse(xhr.responseText);