Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sky/framework/xmlhttprequest.sky

Issue 696373003: Don't GC message pipes that have an in-flight request (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/file-browser.sky ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/xmlhttprequest.sky
diff --git a/sky/framework/xmlhttprequest.sky b/sky/framework/xmlhttprequest.sky
index 1b5505d40847e0b8b77ab59766f8339a72a5eceb..50d92bdfc88e557de5bc39e08acafe0749abe062 100644
--- a/sky/framework/xmlhttprequest.sky
+++ b/sky/framework/xmlhttprequest.sky
@@ -42,11 +42,9 @@ XMLHttpRequest.prototype.send = function() {
var self = this;
this.loader_.start(this.request_).then(function(result) {
- core.drainData(result.response.body).then(function(result) {
+ return core.drainData(result.response.body).then(function(result) {
self.responseText = unicode.decodeUtf8String(new Uint8Array(result.buffer));
self.onload();
- }).catch(function(error) {
- self.onerror(error);
});
}).catch(function(error) {
self.onerror(error);
« no previous file with comments | « sky/examples/file-browser.sky ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698