Issue 696373003: Don't GC message pipes that have an in-flight request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 696373003: Don't GC message pipes that have an in-flight request (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
hansmuller

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Don't GC message pipes that have an in-flight request In mojom, there's a notion of a request/response pair. This CL teaches the JS bindings not to GC a message pipe after a request has been issued but before the response has been received. R=hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f09a4a16ab066c4a6e784a582e11a3ca35d1350

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -30 lines)			Patch
M	mojo/public/js/bindings/router.js	View	6 chunks	+18 lines, -15 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl	View	1 chunk	+8 lines, -11 lines	0 comments	Download
M	sky/examples/file-browser.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/xmlhttprequest.sky	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #1 (id:1) manually as 9f09a4a16ab066c4a6e784a582e11a3ca35d1350.

6 years, 1 month ago (2014-11-04 03:05:51 UTC) #3

Message was sent while issue was closed.

Thanks!

Expand Messages | Collapse Messages