initial checkin for experimenting

initial checkin for experimenting

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c536942dc93d81aeb5df8a62f81582b0bdaa4f54

[reed1, 2014-11-10 19:00:37]

reed@google.com changed reviewers:
+ djsollen@google.com, robertphillips@google.com

[robertphillips, 2014-11-10 19:16:35]

lgtm + 2 questions

https://codereview.chromium.org/696063005/diff/20001/gyp/core.gypi
File gyp/core.gypi (right):

https://codereview.chromium.org/696063005/diff/20001/gyp/core.gypi#newcode49
gyp/core.gypi:49: '<(skia_src_path)/core/SkCanvas.cpp',
Add header too?

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawable.h
File src/core/SkCanvasDrawable.h (right):

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:51: virtual void onDraw(SkCanvas*) = 0;
What do you think about having a default implementation of onGetBounds that just
returns false?

[reed1, 2014-11-10 19:20:03]

https://codereview.chromium.org/696063005/diff/20001/gyp/core.gypi
File gyp/core.gypi (right):

https://codereview.chromium.org/696063005/diff/20001/gyp/core.gypi#newcode49
gyp/core.gypi:49: '<(skia_src_path)/core/SkCanvas.cpp',
On 2014/11/10 19:16:35, robertphillips wrote:
> Add header too?

Done.

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawable.h
File src/core/SkCanvasDrawable.h (right):

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:51: virtual void onDraw(SkCanvas*) = 0;
On 2014/11/10 19:16:35, robertphillips wrote:
> What do you think about having a default implementation of onGetBounds that
just
> returns false?

Done.

[djsollen, 2014-11-10 19:23:39]

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawable.h
File src/core/SkCanvasDrawable.h (right):

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:21: class SkCanvasDrawable : public SkRefCnt {
seems that the only real use case for this is animation, but the class name or
comments don't seem to point that out.  Any other use seems like it would be an
abuse of the API.

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:48: void notifyDrawingChanged();
can you add some comments on this?

[reed1, 2014-11-11 12:46:30]

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawable.h
File src/core/SkCanvasDrawable.h (right):

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:21: class SkCanvasDrawable : public SkRefCnt {
On 2014/11/10 19:23:38, djsollen wrote:
> seems that the only real use case for this is animation, but the class name or
> comments don't seem to point that out.  Any other use seems like it would be
an
> abuse of the API.

I see it as more general. For instance, it could also be thought of as an
image-generator, much like we have for lazy decoded images. Or as a class to
implement state changes in a UI element (e.g. checked or unchecked).

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:48: void notifyDrawingChanged();
On 2014/11/10 19:23:39, djsollen wrote:
> can you add some comments on this?

Done.

[reed1, 2014-11-11 12:47:04]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-11 12:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696063005/40001

[djsollen, 2014-11-11 12:53:12]

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawable.h
File src/core/SkCanvasDrawable.h (right):

https://codereview.chromium.org/696063005/diff/20001/src/core/SkCanvasDrawabl...
src/core/SkCanvasDrawable.h:48: void notifyDrawingChanged();
On 2014/11/11 12:46:30, reed1 wrote:
> On 2014/11/10 19:23:39, djsollen wrote:
> > can you add some comments on this?
> 
> Done.

Did you forget to upload the comments? I don't see them in patch set 3?

[commit-bot: I haz the power, 2014-11-11 12:56:09]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c536942dc93d81aeb5df8a62f81582b0bdaa4f54