Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 695953003: [Password Autofill] Disable one click popup on Android. (Closed)

Created:
6 years, 1 month ago by Garrett Casto
Modified:
6 years, 1 month ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Autofill] Disable one click popup on Android. This is a temporary fix to a bug where the popup is shown then immediately hidden as a result of the keyboard showing. Reverting to the old two click behavior, on Android only, until we can fix the underlying issue. BUG=423464 Committed: https://crrev.com/2c646227ce20163e7a2816487a62cf57a20bb269 Cr-Commit-Position: refs/heads/master@{#302537}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 1 chunk +16 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Garrett Casto
6 years, 1 month ago (2014-11-03 19:26:46 UTC) #2
please use gerrit instead
LGTM % nit https://codereview.chromium.org/695953003/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/695953003/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode328 components/autofill/content/renderer/autofill_agent.cc:328: if (show_suggestions) nit: please use curly ...
6 years, 1 month ago (2014-11-03 23:23:13 UTC) #3
Garrett Casto
https://codereview.chromium.org/695953003/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/695953003/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode328 components/autofill/content/renderer/autofill_agent.cc:328: if (show_suggestions) On 2014/11/03 23:23:12, Rouslan Solomakhin wrote: > ...
6 years, 1 month ago (2014-11-03 23:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695953003/20001
6 years, 1 month ago (2014-11-04 00:02:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 01:14:20 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:14:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c646227ce20163e7a2816487a62cf57a20bb269
Cr-Commit-Position: refs/heads/master@{#302537}

Powered by Google App Engine
This is Rietveld 408576698