Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 695953003: [Password Autofill] Disable one click popup on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 0a9b57fd13bf442ea9e3720934c9adf3248a8dc1..2f59e549032081e20bcd5d0471045f284e3f8302 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -318,13 +318,22 @@ void AutofillAgent::FormControlElementClicked(
bool show_full_suggestion_list = element.isAutofilled() || was_focused;
bool show_password_suggestions_only = !was_focused;
- ShowSuggestions(element,
- true,
- false,
- true,
- false,
- show_full_suggestion_list,
- show_password_suggestions_only);
+
+ // TODO(gcasto): Remove after crbug.com/423464 has been fixed.
+ bool show_suggestions = true;
+#if defined(OS_ANDROID)
+ show_suggestions = was_focused;
+#endif
+
+ if (show_suggestions) {
+ ShowSuggestions(element,
+ true,
+ false,
+ true,
+ false,
+ show_full_suggestion_list,
+ show_password_suggestions_only);
+ }
}
void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {
« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698