Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 695903002: DevTools: don't change current selection on Timeline flame chart when overview window changes (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: don't change current selection on Timeline flame chart when overview window changes Shift+drag is more convenient for specifying the range of interest it's better to avoid also binding the selection to the current range in the overview pane. Waterfall view will still populate its details view with the data for selected range in the overview pane. BUG=426152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
6 years, 1 month ago (2014-10-31 16:50:38 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-11-06 08:43:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695903002/1
6 years, 1 month ago (2014-11-06 08:43:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184904
6 years, 1 month ago (2014-11-06 09:47:32 UTC) #6
pfeldman
6 years, 1 month ago (2014-11-06 14:03:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/704233002/ by pfeldman@chromium.org.

The reason for reverting is: There is a blocking issue of shift+drag being non
discoverable that needs to be addressed first..

Powered by Google App Engine
This is Rietveld 408576698