Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 695903002: DevTools: don't change current selection on Timeline flame chart when overview window changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index d540901a91ad02b1da51accaa6c4f05422cc7dc6..37381f04898119b20e679005933b2acd08db8c7d 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -985,8 +985,14 @@ WebInspector.TimelinePanel.prototype = {
_updateSelectionDetails: function()
{
- if (!this._selection)
- this._selection = WebInspector.TimelineSelection.fromRange(this._windowStartTime, this._windowEndTime);
+ if (!this._selection) {
+ if (this._tracingTimelineModel && this._flameChartEnabledSetting.get()) {
+ this.showInDetails(this.element.ownerDocument.createElement("div"));
+ return;
+ } else {
+ this._selection = WebInspector.TimelineSelection.fromRange(this._windowStartTime, this._windowEndTime);
+ }
+ }
switch (this._selection.type()) {
case WebInspector.TimelineSelection.Type.Record:
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698