Make clicks on <a> request a navigation

Make clicks on <a> request a navigation

Currently our window manager isn't listening for these requests, but it would
work if we loaded sky in wm_flow or example_window_manager.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8b38d7b9743330e78a047e103f57e7892e7c3ed4

[eseidel, 2014-10-31 18:16:54]

lgtm

https://codereview.chromium.org/695803003/diff/1/sky/engine/core/testing/Dumm...
File sky/engine/core/testing/DummyPageHolder.cpp (right):

https://codereview.chromium.org/695803003/diff/1/sky/engine/core/testing/Dumm...
sky/engine/core/testing/DummyPageHolder.cpp:62: // m_page = adoptPtr(new
Page(m_pageClients, 0));
??

[ojan, 2014-10-31 18:17:52]

Is it possible to write a test for this? I'm not too worried about this specific
case. but we should get in the habit of testing new code that we write.

[abarth-chromium, 2014-10-31 18:19:22]

On 2014/10/31 at 18:17:52, ojan wrote:
> Is it possible to write a test for this? I'm not too worried about this
specific case. but we should get in the habit of testing new code that we write.

I can write a unit test that shows the API is being called, but until I add the
code that listens for the API calls, its not going to do anything.  IMHO, the
next CL is the one to test in.

[abarth-chromium, 2014-10-31 18:27:48]

Committed patchset #1 (id:1) manually as
8b38d7b9743330e78a047e103f57e7892e7c3ed4 (presubmit successful).

[abarth-chromium, 2014-10-31 20:16:15]

Turns out the next CL didn't end up with a test.  The issue is that the code
ended up in the SkyDebugger app, which currently isn't tested.  We'll need to
think about how to test it...