Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 695803003: Make clicks on <a> request a navigation (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make clicks on <a> request a navigation Currently our window manager isn't listening for these requests, but it would work if we loaded sky in wm_flow or example_window_manager. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b38d7b9743330e78a047e103f57e7892e7c3ed4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M sky/engine/core/frame/FrameHost.h View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 1 comment Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-31 18:14:48 UTC) #1
eseidel
lgtm https://codereview.chromium.org/695803003/diff/1/sky/engine/core/testing/DummyPageHolder.cpp File sky/engine/core/testing/DummyPageHolder.cpp (right): https://codereview.chromium.org/695803003/diff/1/sky/engine/core/testing/DummyPageHolder.cpp#newcode62 sky/engine/core/testing/DummyPageHolder.cpp:62: // m_page = adoptPtr(new Page(m_pageClients, 0)); ??
6 years, 1 month ago (2014-10-31 18:16:54 UTC) #2
ojan
Is it possible to write a test for this? I'm not too worried about this ...
6 years, 1 month ago (2014-10-31 18:17:52 UTC) #3
abarth-chromium
On 2014/10/31 at 18:17:52, ojan wrote: > Is it possible to write a test for ...
6 years, 1 month ago (2014-10-31 18:19:22 UTC) #4
abarth-chromium
Committed patchset #1 (id:1) manually as 8b38d7b9743330e78a047e103f57e7892e7c3ed4 (presubmit successful).
6 years, 1 month ago (2014-10-31 18:27:48 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-10-31 20:16:15 UTC) #6
Message was sent while issue was closed.
Turns out the next CL didn't end up with a test.  The issue is that the code
ended up in the SkyDebugger app, which currently isn't tested.  We'll need to
think about how to test it...

Powered by Google App Engine
This is Rietveld 408576698