Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: sky/engine/core/frame/FrameHost.h

Issue 695803003: Make clicks on <a> request a navigation (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameHost.cpp » ('j') | sky/engine/core/testing/DummyPageHolder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameHost.h
diff --git a/sky/engine/core/frame/FrameHost.h b/sky/engine/core/frame/FrameHost.h
index f30f392720cd68e9b5c954669d7de0cc44281a89..a39322e28b0edde04acfbe178777a279261c5156 100644
--- a/sky/engine/core/frame/FrameHost.h
+++ b/sky/engine/core/frame/FrameHost.h
@@ -59,7 +59,7 @@ class Visitor;
class FrameHost final : public DummyBase<FrameHost> {
WTF_MAKE_NONCOPYABLE(FrameHost); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
- static PassOwnPtr<FrameHost> create(Page&, ServiceProvider*);
+ static PassOwnPtr<FrameHost> create(Page&, ServiceProvider&);
~FrameHost();
// Careful: This function will eventually be removed.
@@ -68,7 +68,7 @@ public:
Chrome& chrome() const;
UseCounter& useCounter() const;
- ServiceProvider* services() const { return m_services; }
+ ServiceProvider& services() const { return m_services; }
// Corresponds to pixel density of the device where this Page is
// being displayed. In multi-monitor setups this can vary between pages.
@@ -80,10 +80,10 @@ public:
void trace(Visitor*);
private:
- FrameHost(Page&, ServiceProvider*);
+ FrameHost(Page&, ServiceProvider&);
RawPtr<Page> m_page;
- ServiceProvider* m_services;
+ ServiceProvider& m_services;
const OwnPtr<EventHandlerRegistry> m_eventHandlerRegistry;
};
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameHost.cpp » ('j') | sky/engine/core/testing/DummyPageHolder.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698