pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 695773003: move import combinator suggestions into a separate computer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 695773003: move import combinator suggestions into a separate computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/combinator_computer.dart ('k') | pkg/analysis_server/lib/src/services/completion/imported_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index e96fccbc78a4f2d4bfc079c3bcfc87a7c2c5b3da..d30a83afd3851d419d4b2acfce634aa251d6f85c 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -7,6 +7,7 @@ library test.services.completion.dart;

import 'dart:async';

import 'package:analysis_server/src/protocol.dart';

+import 'package:analysis_server/src/services/completion/combinator_computer.dart';

import 'package:analysis_server/src/services/completion/completion_manager.dart';

import 'package:analysis_server/src/services/completion/imported_computer.dart';

import 'package:analysis_server/src/services/completion/invocation_computer.dart';

@@ -93,7 +94,7 @@ class DartCompletionManager extends CompletionManager {

int count = computers.length;

computers.forEach((c) {

c.computeFull(request).then((bool changed) {

- var last = --count == 0;

+ bool last = --count == 0;

if (changed || last) {

sendResults(last);

}

@@ -110,6 +111,7 @@ class DartCompletionManager extends CompletionManager {

computers = [

new KeywordComputer(),

new LocalComputer(),

+ new CombinatorComputer(),

new ImportedComputer(),

new InvocationComputer()];

}