Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 695773003: move import combinator suggestions into a separate computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index 12e64e0a132728a82813fba017bbc19c818f94b3..73f972b6684d1b9954ffab2dbeb9e52870aaa537 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -79,11 +79,6 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
}
@override
- Future<bool> visitCombinator(Combinator node) {
- return _addCombinatorSuggestions(node);
- }
-
- @override
Future<bool> visitExpression(Expression node) {
return _addImportedElementSuggestions(node, excludeVoidReturn: true);
}
@@ -202,19 +197,6 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
return new Future.value(false);
}
- Future _addCombinatorSuggestions(Combinator node) {
- var directive = node.getAncestor((parent) => parent is NamespaceDirective);
- if (directive is NamespaceDirective) {
- LibraryElement library = directive.uriElement;
- LibraryElementSuggestionBuilder.suggestionsFor(
- request,
- CompletionSuggestionKind.IDENTIFIER,
- library);
- return new Future.value(true);
- }
- return new Future.value(false);
- }
-
void _addElementSuggestion(Element element, bool typesOnly,
bool excludeVoidReturn, CompletionRelevance relevance) {

Powered by Google App Engine
This is Rietveld 408576698