Issue 695633003: Objects should be unrefed instead of deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 695633003: Objects should be unrefed instead of deleted (Closed)

Created:
6 years, 1 month ago by sugoi1

Modified:
6 years, 1 month ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Objects should be unrefed instead of deleted When an error occurs reading a flattenable object, it should be unrefed instead of deleted because, in the case of SkXferMode, for example, we'd actually be deleting a cached object kept in a static array. BUG=428789 Committed: https://skia.googlesource.com/skia/+/8b602ddd59f7016f50b4ea27dacfe4788cf07c14

Patch Set 1 #

Patch Set 2 : Use after free issue fixed #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkValidatingReadBuffer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695633003/20001

6 years, 1 month ago (2014-10-31 12:20:07 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-31 14:16:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 8b602ddd59f7016f50b4ea27dacfe4788cf07c14

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages