src/core/SkValidatingReadBuffer.cpp - Issue 695633003: Objects should be unrefed instead of deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkValidatingReadBuffer.cpp

Issue 695633003: Objects should be unrefed instead of deleted (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Use after free issue fixed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkValidatingReadBuffer.cpp

diff --git a/src/core/SkValidatingReadBuffer.cpp b/src/core/SkValidatingReadBuffer.cpp

index 037a99465b2853f34627b379ba32323277a3f3ea..96b08639361de35e29c1691308ef7af3bc733390 100644

--- a/src/core/SkValidatingReadBuffer.cpp

+++ b/src/core/SkValidatingReadBuffer.cpp

@@ -250,7 +250,7 @@ SkFlattenable* SkValidatingReadBuffer::readFlattenable(SkFlattenable::Type type)

this->validate(sizeRecorded == sizeRead);

if (fError) {

// we could try to fix up the offset...

- delete obj;

+ SkSafeUnref(obj);

obj = NULL;

}

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »