grit/format/policy_templates/writers/admx_writer.py - Issue 695613003: Fix duplicated strings in ADMX templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/admx_writer.py

Issue 695613003: Fix duplicated strings in ADMX templates. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: added tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: grit/format/policy_templates/writers/admx_writer.py

diff --git a/grit/format/policy_templates/writers/admx_writer.py b/grit/format/policy_templates/writers/admx_writer.py

index 0d4394b9d136e35aabd2aff7fe08fa72bda77636..a9ea49ca3d818cdb8fbc92d890865a5d47519be7 100644

--- a/grit/format/policy_templates/writers/admx_writer.py

+++ b/grit/format/policy_templates/writers/admx_writer.py

@@ -32,6 +32,7 @@ class ADMXWriter(xml_formatted_writer.XMLFormattedWriter):

Args:

name: Name of the referenced ADML string.

'''

+ name = name.replace('.', '_')

return '$(string.' + name + ')'

def _AdmlStringExplain(self, name):

@@ -39,6 +40,7 @@ class ADMXWriter(xml_formatted_writer.XMLFormattedWriter):

Args:

name: Name of the referenced ADML explanation.

'''

+ name = name.replace('.', '_')

return '$(string.' + name + '_Explain)'

def _AdmlPresentation(self, name):