Subzero: Use a common RelocOffsetType / RelocOffsetT.

Subzero: Use a common RelocOffsetType / RelocOffsetT.

There is one in IceDefs.h and one in IceGlobalInits.h. Can we just use one?

BUG=none (mini cleanup)
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c0d965fc28d1ef134b34bea7825399639c88e9d6

[jvoung (off chromium), 2014-11-04 19:19:52]

jvoung@chromium.org changed reviewers:
+ kschimpf@chromium.org, stichnot@chromium.org

[jvoung (off chromium), 2014-11-04 19:21:55]

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h#newcode232
src/IceGlobalInits.h:232: SizeT getNumBytes() const final { return
sizeof(RelocOffsetT); }
or I can keep the constant, and put it alongside RelocOffsetT

[Jim Stichnoth, 2014-11-04 19:28:55]

LGTM, as long as Karl agrees.

[Karl, 2014-11-04 20:15:00]

kschimpf@google.com changed reviewers:
+ kschimpf@google.com

[Karl, 2014-11-04 20:15:00]

lgtm

LGTM.

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h#newcode232
src/IceGlobalInits.h:232: SizeT getNumBytes() const final { return
sizeof(RelocOffsetT); }
On 2014/11/04 19:21:55, jvoung wrote:
> or I can keep the constant, and put it alongside RelocOffsetT

I would prefer the constant, in case we change the type of SizeT. The size must
always be 4.

[Jim Stichnoth, 2014-11-04 20:18:05]

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h#newcode232
src/IceGlobalInits.h:232: SizeT getNumBytes() const final { return
sizeof(RelocOffsetT); }
On 2014/11/04 20:15:00, Karl wrote:
> On 2014/11/04 19:21:55, jvoung wrote:
> > or I can keep the constant, and put it alongside RelocOffsetT
> 
> I would prefer the constant, in case we change the type of SizeT. The size
must
> always be 4.

But RelocOffsetT (as well as RelocOffsetType) is defined at int32_t, which will
always be 4.

[Karl, 2014-11-04 23:01:21]

lgtm

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h
File src/IceGlobalInits.h (right):

https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h#newcode232
src/IceGlobalInits.h:232: SizeT getNumBytes() const final { return
sizeof(RelocOffsetT); }
On 2014/11/04 20:18:05, stichnot wrote:
> On 2014/11/04 20:15:00, Karl wrote:
> > On 2014/11/04 19:21:55, jvoung wrote:
> > > or I can keep the constant, and put it alongside RelocOffsetT
> > 
> > I would prefer the constant, in case we change the type of SizeT. The size
> must
> > always be 4.
> 
> But RelocOffsetT (as well as RelocOffsetType) is defined at int32_t, which
will
> always be 4.

I have no problem with this, so long as a comment is added to RelocOffsetType
(if not already there) that it must be 4 bytes long.

[jvoung (off chromium), 2014-11-04 23:04:42]

On 2014/11/04 23:01:21, Karl wrote:
> lgtm
> 
> https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h
> File src/IceGlobalInits.h (right):
> 
>
https://codereview.chromium.org/695563006/diff/1/src/IceGlobalInits.h#newcode232
> src/IceGlobalInits.h:232: SizeT getNumBytes() const final { return
> sizeof(RelocOffsetT); }
> On 2014/11/04 20:18:05, stichnot wrote:
> > On 2014/11/04 20:15:00, Karl wrote:
> > > On 2014/11/04 19:21:55, jvoung wrote:
> > > > or I can keep the constant, and put it alongside RelocOffsetT
> > > 
> > > I would prefer the constant, in case we change the type of SizeT. The size
> > must
> > > always be 4.
> > 
> > But RelocOffsetT (as well as RelocOffsetType) is defined at int32_t, which
> will
> > always be 4.
> 
> I have no problem with this, so long as a comment is added to RelocOffsetType
> (if not already there) that it must be 4 bytes long.


Okay, given that the location of the sizeof() and the typedef aren't so close, I
ended up adding back a constant, near the typedef so that it's clear the size is
being used somewhere (so don't change the typedef without thinking about the
size too).

[jvoung (off chromium), 2014-11-05 00:55:05]

Committed patchset #3 (id:40001) manually as
c0d965fc28d1ef134b34bea7825399639c88e9d6 (presubmit successful).