Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: src/IceGlobalInits.h

Issue 695563006: Subzero: Use a common RelocOffsetType / RelocOffsetT. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: format-diff Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceDefs.h ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceGlobalInits.h
diff --git a/src/IceGlobalInits.h b/src/IceGlobalInits.h
index b4c629943abfc725fb2792a3390315aaf164a562..d5974b41139e4e34f87a4811b11c4ad5668b30d9 100644
--- a/src/IceGlobalInits.h
+++ b/src/IceGlobalInits.h
@@ -216,22 +216,17 @@ public:
SizeT Size;
};
- // Relocation address offsets must be 32 bit values.
- typedef int32_t RelocOffsetType;
- static const SizeT RelocAddrSize = 4;
-
/// Defines the relocation value of another global declaration.
class RelocInitializer : public Initializer {
RelocInitializer(const RelocInitializer &) = delete;
RelocInitializer &operator=(const RelocInitializer &) = delete;
public:
- RelocInitializer(const GlobalDeclaration *Declaration,
- RelocOffsetType Offset)
+ RelocInitializer(const GlobalDeclaration *Declaration, RelocOffsetT Offset)
: Initializer(RelocInitializerKind), Declaration(Declaration),
Offset(Offset) {}
~RelocInitializer() override {}
- RelocOffsetType getOffset() const { return Offset; }
+ RelocOffsetT getOffset() const { return Offset; }
const GlobalDeclaration *getDeclaration() const { return Declaration; }
SizeT getNumBytes() const final { return RelocAddrSize; }
void dump(GlobalContext *Ctx, Ostream &Stream) const final;
@@ -244,7 +239,7 @@ public:
// The global declaration used in the relocation.
const GlobalDeclaration *Declaration;
// The offset to add to the relocation.
- const RelocOffsetType Offset;
+ const RelocOffsetT Offset;
};
/// Models the list of initializers.
« no previous file with comments | « src/IceDefs.h ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698