Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: test/common_e2e.dart

Issue 695533003: Increase delay when after eventually consistent operations in datastore/storage (Closed) Base URL: git@github.com:dart-lang/gcloud.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .status ('k') | test/datastore/e2e/datastore_test_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/common_e2e.dart
diff --git a/test/common_e2e.dart b/test/common_e2e.dart
index 976eee54b78ce451d1decc62528df17800b1b379..4690d4f460967b467d6735000ae59b9d168fed69 100644
--- a/test/common_e2e.dart
+++ b/test/common_e2e.dart
@@ -26,6 +26,26 @@ const String DEFAULT_PROJECT = 'dart-gcloud-e2e';
const String DEFAULT_KEY_LOCATION =
'gs://dart-archive-internal/keys/dart-gcloud-e2e.json';
+// Used for db/datastore e2e tests:
+//
+// Non-ancestor queries (i.e. queries not lookups) result in index scans.
+// The index tables are updated in a "eventually consistent" way.
+//
+// So this can make tests flaky, if the index updates take longer than the
+// following constant.
+const INDEX_UPDATE_DELAY = const Duration(seconds: 20);
+
+// Used for storage e2e tests:
+//
+// List operations on buckets are eventually consistent. Bucket deletion is
+// also dependent on list operations to ensure the bucket is empty before
+// deletion.
+//
+// So this can make tests flakky. The following delay is introduced as an
Søren Gjesse 2014/11/03 14:06:48 flakky -> flaky
kustermann 2014/11/03 14:07:48 Done.
+// attempt to account for that.
+const STORAGE_LIST_DELAY = const Duration(seconds: 5);
+
+
bool onBot() {
// When running on the package-bot the current user is chrome-bot.
var envName;
« no previous file with comments | « .status ('k') | test/datastore/e2e/datastore_test_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698