chrome/browser/background/background_contents_service.cc - Issue 695133005: Temporarily disable extensions and sync while a profile is locked - Profiles Approach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 695133005: Temporarily disable extensions and sync while a profile is locked - Profiles Approach (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test. Don't lock policy-forced extensions. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc » ('j') | chrome/browser/extensions/extension_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 3b87006e1d76365b6d5286d62ce719ca6ab42ba2..e10954ece7334c040f7c1e18eed248e2136a5351 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -454,10 +454,11 @@ void BackgroundContentsService::OnExtensionUnloaded(

const extensions::Extension* extension,

extensions::UnloadedExtensionInfo::Reason reason) {

switch (reason) {

- case UnloadedExtensionInfo::REASON_DISABLE: // Fall through.

- case UnloadedExtensionInfo::REASON_TERMINATE: // Fall through.

- case UnloadedExtensionInfo::REASON_UNINSTALL: // Fall through.

- case UnloadedExtensionInfo::REASON_BLACKLIST: // Fall through.

+ case UnloadedExtensionInfo::REASON_DISABLE: // Fall through.

+ case UnloadedExtensionInfo::REASON_TERMINATE: // Fall through.

+ case UnloadedExtensionInfo::REASON_UNINSTALL: // Fall through.

+ case UnloadedExtensionInfo::REASON_BLACKLIST: // Fall through.

+ case UnloadedExtensionInfo::REASON_PROFILE_LOCK: // Fall through.

case UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN:

ShutdownAssociatedBackgroundContents(base::ASCIIToUTF16(extension->id()));

SendChangeNotification(Profile::FromBrowserContext(browser_context));