Temporarily disable extensions and sync while a profile is locked - Profiles Approach

chrome/browser/background/background_contents_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background/background_contents_service.h"
 
 #include "apps/app_load_service.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 436 matching lines @@
   // Close the crash notification balloon for the app/extension, if any.
   ScheduleCloseBalloon(extension->id(), profile);
   SendChangeNotification(profile);
 }
 
 void BackgroundContentsService::OnExtensionUnloaded(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension,
     extensions::UnloadedExtensionInfo::Reason reason) {
   switch (reason) {
-    case UnloadedExtensionInfo::REASON_DISABLE:    // Fall through.
-    case UnloadedExtensionInfo::REASON_TERMINATE:  // Fall through.
-    case UnloadedExtensionInfo::REASON_UNINSTALL:  // Fall through.
-    case UnloadedExtensionInfo::REASON_BLACKLIST:  // Fall through.
+    case UnloadedExtensionInfo::REASON_DISABLE:       // Fall through.
+    case UnloadedExtensionInfo::REASON_TERMINATE:     // Fall through.
+    case UnloadedExtensionInfo::REASON_UNINSTALL:     // Fall through.
+    case UnloadedExtensionInfo::REASON_BLACKLIST:     // Fall through.
+    case UnloadedExtensionInfo::REASON_PROFILE_LOCK:  // Fall through.
     case UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN:
       ShutdownAssociatedBackgroundContents(base::ASCIIToUTF16(extension->id()));
       SendChangeNotification(Profile::FromBrowserContext(browser_context));
       break;
     case UnloadedExtensionInfo::REASON_UPDATE: {
       // If there is a manifest specified background page, then shut it down
       // here, since if the updated extension still has the background page,
       // then it will be loaded from LOADED callback. Otherwise, leave
       // BackgroundContents in place.
       // We don't call SendChangeNotification here - it will be generated
       // from the LOADED callback.
       if (BackgroundInfo::HasBackgroundPage(extension)) {
         ShutdownAssociatedBackgroundContents(
             base::ASCIIToUTF16(extension->id()));
       }
       break;
     }
     default:

[not at google - send to devlin, 2014/11/12 18:22:59]

Cleanup: could you remove this default case entirely, and change the 'break's
above to 'return's, then move that NOTREACHED and Shutdown(...) to after the
switch. Nicer compiler errors.

[Mike Lerman, 2014/11/12 20:58:41]

Done.

       NOTREACHED();
       ShutdownAssociatedBackgroundContents(base::ASCIIToUTF16(extension->id()));
       break;
   }
 }
 
 void BackgroundContentsService::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension,
     extensions::UninstallReason reason) {
@@ skipping 281 matching lines @@
     bool user_gesture,
     bool* was_blocked) {
   Browser* browser = chrome::FindLastActiveWithProfile(
       Profile::FromBrowserContext(new_contents->GetBrowserContext()),
       chrome::GetActiveDesktop());
   if (browser) {
     chrome::AddWebContents(browser, NULL, new_contents, disposition,
                            initial_pos, user_gesture, was_blocked);
   }
 }