Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 695043002: Specs: make element registrations be per-module, define how they are (Closed)

Created:
6 years, 1 month ago by Hixie
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Specs: make element registrations be per-module, define how they are exported and reexported, rename 'interface' to 'class' in the IDL, add constructors to all registered elements R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/24f44cd9d48cb4308251b0176f2d895a6245e57e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -54 lines) Patch
M sky/README.md View 1 chunk +2 lines, -2 lines 1 comment Download
M sky/examples/radio.sky View 3 chunks +6 lines, -4 lines 0 comments Download
M sky/specs/apis.md View 15 chunks +122 lines, -48 lines 1 comment Download
M sky/specs/modules.md View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
lgtm https://codereview.chromium.org/695043002/diff/1/sky/README.md File sky/README.md (right): https://codereview.chromium.org/695043002/diff/1/sky/README.md#newcode78 sky/README.md:78: this.shadowRoot.firstChild.replaceWith(new Date()); I assume this does a toString() ...
6 years, 1 month ago (2014-10-31 23:13:44 UTC) #2
Hixie
On 2014/10/31 23:13:44, esprehn wrote: > lgtm > > https://codereview.chromium.org/695043002/diff/1/sky/README.md > File sky/README.md (right): > ...
6 years, 1 month ago (2014-10-31 23:15:36 UTC) #3
Hixie
6 years, 1 month ago (2014-10-31 23:18:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24f44cd9d48cb4308251b0176f2d895a6245e57e.

Powered by Google App Engine
This is Rietveld 408576698