sky/README.md - Issue 695043002: Specs: make element registrations be per-module, define how they are

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/README.md

Issue 695043002: Specs: make element registrations be per-module, define how they are (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/README.md

diff --git a/sky/README.md b/sky/README.md

index ac266620943d4e0719f134e6823e6996531f6cdd..8a5673248d615f70d3d4250b768efe06b880b6a9 100644

--- a/sky/README.md

+++ b/sky/README.md

@@ -72,10 +72,10 @@ SKY MODULE

class extends SkyElement {

constructor () {

this.addEventListener('click', (event) => this.updateTime());

- this.createShadowTree().appendChild('Click to show the time');

+ this.shadowRoot.appendChild('Click to show the time');

}

updateTime() {

- this.shadowTree.firstChild.replaceWith(new Date());

+ this.shadowRoot.firstChild.replaceWith(new Date());

esprehn 2014/10/31 23:13:44 I assume this does a toString() since it's not a N

}

</sky-element>

« no previous file with comments | « no previous file | sky/examples/radio.sky » ('j') | sky/specs/apis.md » ('J')