Issue 694983002: Revert of GrContext no longer ever draws on Gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 694983002: Revert of GrContext no longer ever draws on Gpu (Closed)

Created:
6 years, 1 month ago by joshualitt

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of GrContext no longer ever draws on Gpu (patchset #7 id:120001 of https://codereview.chromium.org/683733005/) Reason for revert: breaks some android bots Original issue's description: > GrContext no longer ever draws on Gpu > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7a75e5230872732e71ea99058d9afe5d4b6758b0 TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b9e8230b50fc383869ee64208e23e5b6403568a1

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -40 lines)			Patch
M	include/gpu/GrContext.h	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View	20 chunks	+58 lines, -39 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of GrContext no longer ever draws on Gpu

6 years, 1 month ago (2014-10-31 19:19:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694983002/1

6 years, 1 month ago (2014-10-31 19:19:59 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-31 19:20:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as b9e8230b50fc383869ee64208e23e5b6403568a1