Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 694963002: util/net: Place death tests into a *DeathTest test case (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

util/net: Place death tests into a *DeathTest test case. Not doing this causes gtest to issue these warnings: [WARNING] ../../third_party/gtest/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads. The gtest documentation recommends giving the test case a name ending in DeathTest. Test cases named according to this convention run before all other tests. Other death tests in Crashpad also follow this convention. https://code.google.com/p/googletest/wiki/AdvancedGuide#Death_Tests_And_Threads TEST=util_test HTTPMultipartBuilderDeathTest.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/486429e4f4da4a1b54e07acd89abb99e2330da4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/net/http_multipart_builder_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-10-31 19:00:02 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-10-31 19:22:29 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-10-31 19:39:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
486429e4f4da4a1b54e07acd89abb99e2330da4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698