Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: util/net/http_multipart_builder_test.cc

Issue 694963002: util/net: Place death tests into a *DeathTest test case (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 EXPECT_EQ(boundary, *lines_it++); 241 EXPECT_EQ(boundary, *lines_it++);
242 EXPECT_EQ("Content-Disposition: form-data; name=\"one\"", *lines_it++); 242 EXPECT_EQ("Content-Disposition: form-data; name=\"one\"", *lines_it++);
243 EXPECT_EQ("", *lines_it++); 243 EXPECT_EQ("", *lines_it++);
244 EXPECT_EQ(kValue1, *lines_it++); 244 EXPECT_EQ(kValue1, *lines_it++);
245 245
246 EXPECT_EQ(boundary + "--", *lines_it++); 246 EXPECT_EQ(boundary + "--", *lines_it++);
247 247
248 EXPECT_EQ(lines.end(), lines_it); 248 EXPECT_EQ(lines.end(), lines_it);
249 } 249 }
250 250
251 TEST(HTTPMultipartBuilder, AssertUnsafeMIMEType) { 251 TEST(HTTPMultipartBuilderDeathTest, AssertUnsafeMIMEType) {
252 HTTPMultipartBuilder builder; 252 HTTPMultipartBuilder builder;
253 // Invalid and potentially dangerous: 253 // Invalid and potentially dangerous:
254 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\r\n"), ""); 254 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\r\n"), "");
255 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\""), ""); 255 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\""), "");
256 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\x12"), ""); 256 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "\x12"), "");
257 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "<>"), ""); 257 ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "<>"), "");
258 // Invalid but safe: 258 // Invalid but safe:
259 builder.SetFileAttachment("", "", base::FilePath(), "0/totally/-invalid.pdf"); 259 builder.SetFileAttachment("", "", base::FilePath(), "0/totally/-invalid.pdf");
260 // Valid and safe: 260 // Valid and safe:
261 builder.SetFileAttachment("", "", base::FilePath(), "application/xml+xhtml"); 261 builder.SetFileAttachment("", "", base::FilePath(), "application/xml+xhtml");
262 } 262 }
263 263
264 } // namespace 264 } // namespace
265 } // namespace test 265 } // namespace test
266 } // namespace crashpad 266 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698