Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694923002: Update mojo sdk to rev 91d94d6993c9b0c4135a95687a7d541ce90629b (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
Aaron Boodman, aa1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 91d94d6993c9b0c4135a95687a7d541ce90629b Also includes changes from https://codereview.chromium.org/695953002/ to update html_viewer for API changes. Committed: https://crrev.com/904ce270798bd27f4f6fa4348838b00ee6e9a408 Cr-Commit-Position: refs/heads/master@{#302333}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : update version to 8c71ea8f07989d102ea575f4d75947392900c414 #

Patch Set 4 : update to 91d94d6993c9b0c4135a95687a7d541ce90629b7 #

Patch Set 5 : include https://codereview.chromium.org/687863003/ #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -229 lines) Patch
M mojo/application_manager/application_manager.h View 4 chunks +9 lines, -1 line 0 comments Download
M mojo/application_manager/application_manager.cc View 8 chunks +58 lines, -15 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 2 chunks +11 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +20 lines, -7 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M mojo/public/VERSION View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/application_test_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 2 3 4 5 2 chunks +21 lines, -53 lines 0 comments Download
A + mojo/public/cpp/application/lib/application_test_main.cc View 2 chunks +7 lines, -51 lines 0 comments Download
M mojo/public/cpp/environment/environment.h View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M mojo/public/js/bindings/connection.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 1 4 chunks +13 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 4 chunks +13 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/public/cpp/geometry/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
A mojo/services/public/cpp/geometry/geometry_util.h View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A + mojo/services/public/cpp/surfaces/BUILD.gn View 1 chunk +4 lines, -6 lines 0 comments Download
A + mojo/services/public/cpp/surfaces/surfaces_utils.h View 1 chunk +6 lines, -10 lines 0 comments Download
A mojo/services/public/cpp/surfaces/surfaces_utils.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/window_manager/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 1 chunk +6 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jamesr
6 years, 1 month ago (2014-10-31 18:20:43 UTC) #2
Aaron Boodman
lgtm w/ nit https://codereview.chromium.org/694923002/diff/1/mojo/services/html_viewer/html_document_view.h File mojo/services/html_viewer/html_document_view.h (right): https://codereview.chromium.org/694923002/diff/1/mojo/services/html_viewer/html_document_view.h#newcode58 mojo/services/html_viewer/html_document_view.h:58: ServiceProviderPtr provider) override; Wrong wrapping?
6 years, 1 month ago (2014-10-31 18:38:49 UTC) #4
jamesr
Will update to mojo 58044b38c9e52bf6df2d32e0d063c9529021e3ce to pick up https://codereview.chromium.org/686103003/ https://codereview.chromium.org/694923002/diff/1/mojo/services/html_viewer/html_document_view.h File mojo/services/html_viewer/html_document_view.h (right): https://codereview.chromium.org/694923002/diff/1/mojo/services/html_viewer/html_document_view.h#newcode58 mojo/services/html_viewer/html_document_view.h:58: ...
6 years, 1 month ago (2014-10-31 19:05:10 UTC) #5
jamesr
Appears that https://codereview.chromium.org/665083008 doesn't work on windows (and possibly not on android either).
6 years, 1 month ago (2014-10-31 19:21:37 UTC) #6
jamesr
Trying again without that...
6 years, 1 month ago (2014-10-31 19:31:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694923002/100001
6 years, 1 month ago (2014-10-31 20:24:34 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-10-31 22:08:41 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:09:43 UTC) #11
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/904ce270798bd27f4f6fa4348838b00ee6e9a408
Cr-Commit-Position: refs/heads/master@{#302333}

Powered by Google App Engine
This is Rietveld 408576698