Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 665083008: Refactor bindings generation in GYP (Closed)

Created:
6 years, 1 month ago by Nick Bray (chromium)
Modified:
6 years, 1 month ago
Reviewers:
jamesr, bradn
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, teravest
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Refactor bindings generation in GYP Bindings generation needs to be separated from compilation to work with NaCl. Interface generation in mojo_public.gyp was ported to use the new pattern to ensure the code is live. BUG=https://code.google.com/p/chromium/issues/detail?id=401761 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/12a220862704551c94aec4516bd62af71b4d3d6e

Patch Set 1 #

Total comments: 6

Patch Set 2 : GYP hackery #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -42 lines) Patch
M mojo/public/mojo_public.gyp View 2 chunks +35 lines, -21 lines 0 comments Download
A + mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi View 1 2 chunks +28 lines, -21 lines 1 comment Download
A mojo/public/tools/bindings/mojom_list_outputs.py View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nick Bray (chromium)
6 years, 1 month ago (2014-10-28 00:04:39 UTC) #2
jamesr
https://codereview.chromium.org/665083008/diff/1/mojo/public/mojo_public.gyp File mojo/public/mojo_public.gyp (right): https://codereview.chromium.org/665083008/diff/1/mojo/public/mojo_public.gyp#newcode198 mojo/public/mojo_public.gyp:198: 'includes': [ 'tools/bindings/mojom_bindings_generator_explicit.gypi' ], does this script exist? where ...
6 years, 1 month ago (2014-10-28 00:54:21 UTC) #3
Nick Bray (chromium)
https://codereview.chromium.org/665083008/diff/1/mojo/public/mojo_public.gyp File mojo/public/mojo_public.gyp (right): https://codereview.chromium.org/665083008/diff/1/mojo/public/mojo_public.gyp#newcode198 mojo/public/mojo_public.gyp:198: 'includes': [ 'tools/bindings/mojom_bindings_generator_explicit.gypi' ], On 2014/10/28 00:54:21, jamesr wrote: ...
6 years, 1 month ago (2014-10-28 20:57:24 UTC) #4
jamesr
cool, I understand now. lgtm
6 years, 1 month ago (2014-10-29 00:28:33 UTC) #5
Nick Bray (chromium)
Committed patchset #4 (id:60001) manually as 12a220862704551c94aec4516bd62af71b4d3d6e (presubmit successful).
6 years, 1 month ago (2014-10-29 18:15:23 UTC) #6
bradn
6 years, 1 month ago (2014-11-11 23:48:23 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/665083008/diff/60001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi (right):

https://codereview.chromium.org/665083008/diff/60001/mojo/public/tools/bindin...
mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi:111: # Include
paths needed to find the generated header files and their transitive
>80

Powered by Google App Engine
This is Rietveld 408576698