Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 694883002: Do not allow split view to be engaged by a bezel gesture (Closed)

Created:
6 years, 1 month ago by tdanderson
Modified:
6 years, 1 month ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not allow split view to be engaged by a bezel gesture Remove the ability to engage split view mode with the use of a bezel gesture, and remove BezelController which is currently only used for this purpose. BUG=429184 TEST=WindowManagerTest.TitleDragSwitchBetweenWindowsInSplitViewMode renamed to WindowManagerTest.ReplaceWindowsInSplitViewMode and modified, WindowManagerTest.BezelGestureToSplitViewMode removed, WindowManagerTest.BezelGestureToSwitchBetweenWindows removed Committed: https://crrev.com/ee6e2e338dd8e7214e34f492a3aba08717599fd0 Cr-Commit-Position: refs/heads/master@{#302436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -475 lines) Patch
M athena/athena.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D athena/wm/bezel_controller.h View 1 chunk +0 lines, -101 lines 0 comments Download
D athena/wm/bezel_controller.cc View 1 chunk +0 lines, -209 lines 0 comments Download
M athena/wm/split_view_controller.h View 3 chunks +1 line, -9 lines 0 comments Download
M athena/wm/split_view_controller.cc View 2 chunks +7 lines, -58 lines 0 comments Download
M athena/wm/window_manager_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 5 chunks +2 lines, -9 lines 0 comments Download
M athena/wm/window_manager_unittest.cc View 3 chunks +40 lines, -85 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
mukai@, can you please take a look?
6 years, 1 month ago (2014-10-31 17:25:04 UTC) #2
Jun Mukai
lgtm
6 years, 1 month ago (2014-10-31 23:43:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694883002/1
6 years, 1 month ago (2014-11-03 15:59:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 16:39:46 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 16:40:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee6e2e338dd8e7214e34f492a3aba08717599fd0
Cr-Commit-Position: refs/heads/master@{#302436}

Powered by Google App Engine
This is Rietveld 408576698