Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 694853003: Fix GN warnings about expected grit output files. (Closed)

Created:
6 years, 1 month ago by lliabraa
Modified:
6 years, 1 month ago
Reviewers:
jamesr, oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix GN warnings about expected grit output files. CL https://codereview.chromium.org/633373010 added some output files but did not update the expected output files in the corresponding GN files. BUG=429299 TBR=jochen@chromium.org Committed: https://crrev.com/ea7d7405a54d2380247ff86814537e3ddfc16ba3 Cr-Commit-Position: refs/heads/master@{#302334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/app/theme/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
lliabraa
+jamesr for review +oshima for OWNERS
6 years, 1 month ago (2014-10-31 21:08:28 UTC) #2
jamesr
thanks, lgtm
6 years, 1 month ago (2014-10-31 21:09:58 UTC) #3
oshima
lgtm
6 years, 1 month ago (2014-10-31 21:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694853003/1
6 years, 1 month ago (2014-10-31 21:20:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21603)
6 years, 1 month ago (2014-10-31 21:26:44 UTC) #8
lliabraa
TBR jochen who LG'd the original change.
6 years, 1 month ago (2014-10-31 21:41:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694853003/1
6 years, 1 month ago (2014-10-31 21:42:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 22:09:45 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:10:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea7d7405a54d2380247ff86814537e3ddfc16ba3
Cr-Commit-Position: refs/heads/master@{#302334}

Powered by Google App Engine
This is Rietveld 408576698