Generate chrome_300_percent.pak

Generate chrome_300_percent.pak

This CL updates chrome/chrome_resources.gyp to generate the
chrome_300_percent.pak file (via the newly-added
chrome/chrome_repack_chrome_300_percent.gypi).

Several .grd files have been updated to generate the
*_300_percent.pak files that are used to create
chrome_300_percent.pak.

This CL doesn't add any assets but grit complains if the
necessary default_300_percent directories are not present
so this CL adds placeholder files in these directories until
real assets are added (which is tracked by crbug.com/423755).

Since there are no assets in the *_300_percent directories,
grit will fallback to using the 1x versions when generating the
*_300_percent.pak files.

Note that 300 percent support will be enabled in
ui/base/resources by a subsequent CL
(https://chromiumcodereview.appspot.com/646773004/).

BUG=423762
Committed: https://crrev.com/ca09c95ee45362dfb4a50a9d22a6f8195d28bc41
Cr-Commit-Position: refs/heads/master@{#300869}

[lliabraa, 2014-10-15 19:27:36]

lliabraa@chromium.org changed reviewers:
+ rohitrao@chromium.org

[lliabraa, 2014-10-17 12:19:57]

lliabraa@chromium.org changed reviewers:
+ tony@chromium.org

[lliabraa, 2014-10-17 12:19:58]

+tony

Rohit and I have discussed this CL and he's +1 from an iOS perspective but both
of us were surprised that no other platforms are using 300 percent yet. Are we
missing something? Should we only be generating the 300 percent pak files for
iOS (not sure if grd/grit allows it).

[tony, 2014-10-17 16:46:19]

tony@chromium.org changed reviewers:
+ oshima@chromium.org

[tony, 2014-10-17 16:53:03]

AFAIK, iOS is the first to use 300 percent images.  Oshima probably knows more
than me (I haven't worked on Chromium for over a year now).  Looks like we'll
need to generate the 300 percent resources.

[oshima, 2014-10-17 17:18:21]

Yes, desktop chrome only supports up to 2x.

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_repack_chrome_...
File chrome/chrome_repack_chrome_300_percent.gypi (right):

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_repack_chrome_...
chrome/chrome_repack_chrome_300_percent.gypi:41: }],
Can you just add what's necessary? These extra resources will not have 3x assets
anytime soon. (at least I'm not aware of such plan)

Please add comment that this is used only for ios for now, and needs to be
updated in order to be used for other platforms.

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (right):

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_resources.gyp#...
chrome/chrome_resources.gyp:440: },
And it's probably better to generate this only for ios as 3x pak won't be useful
for other platforms.

[lliabraa, 2014-10-21 14:25:09]

thanks for the review

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_repack_chrome_...
File chrome/chrome_repack_chrome_300_percent.gypi (right):

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_repack_chrome_...
chrome/chrome_repack_chrome_300_percent.gypi:41: }],
On 2014/10/17 17:18:21, oshima wrote:
> Can you just add what's necessary? These extra resources will not have 3x
assets
> anytime soon. (at least I'm not aware of such plan)
> 
> Please add comment that this is used only for ios for now, and needs to be
> updated in order to be used for other platforms.

Done.

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_resources.gyp
File chrome/chrome_resources.gyp (right):

https://codereview.chromium.org/633373010/diff/1/chrome/chrome_resources.gyp#...
chrome/chrome_resources.gyp:440: },
On 2014/10/17 17:18:21, oshima wrote:
> And it's probably better to generate this only for ios as 3x pak won't be
useful
> for other platforms.

Done.

[oshima, 2014-10-21 22:17:11]

lgtm

[lliabraa, 2014-10-22 11:36:00]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-10-22 11:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633373010/40001

[commit-bot: I haz the power, 2014-10-22 11:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 11:41:14]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[lliabraa, 2014-10-22 11:52:41]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-10-22 11:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633373010/60001

[lliabraa, 2014-10-22 11:56:44]

lliabraa@chromium.org changed reviewers:
+ jochen@chromium.org

[lliabraa, 2014-10-22 11:56:45]

+jochen for OWNERS

[commit-bot: I haz the power, 2014-10-22 11:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 11:58:12]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[lliabraa, 2014-10-22 13:53:15]

On 2014/10/22 11:58:12, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win8_chromium_rel on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

@jochen - Specifically, I need OWNERS review on:
    chrome/chrome_resources.gyp
    chrome/renderer/resources/default_300_percent/DELETE_ME
    chrome/renderer/resources/renderer_resources.grd
    components/resources/components_scaled_resources.grd
    components/resources/default_300_percent/DELETE_ME

[jochen (gone - plz use gerrit), 2014-10-22 15:25:39]

why do you need all those delete_me files?

[lliabraa, 2014-10-22 15:59:13]

On 2014/10/22 15:25:39, jochen wrote:
> why do you need all those delete_me files?

I don't have 3x assets to put in the 300_percent directories yet, but if the
directories don't exist then grit fails. git doesn't support empty directories
so the DELETE_ME files are placeholders.

[jochen (gone - plz use gerrit), 2014-10-23 09:35:46]

ok, lgtm

[lliabraa, 2014-10-23 10:43:30]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-10-23 10:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633373010/60001

[commit-bot: I haz the power, 2014-10-23 11:41:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-23 11:41:58]

Patchset 4 (id:??) landed as
https://crrev.com/ca09c95ee45362dfb4a50a9d22a6f8195d28bc41
Cr-Commit-Position: refs/heads/master@{#300869}