Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/android/android_provider_backend_unittest.cc
diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc
index 56b1bd419a661b3470217a982535d7e9dc201a50..6867884136802fca44c9c735a2051b913be85ffb 100644
--- a/chrome/browser/history/android/android_provider_backend_unittest.cc
+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc
@@ -80,25 +80,16 @@ class AndroidProviderBackendDelegate : public HistoryBackend::Delegate {
const history::URLRow& row,
const history::RedirectList& redirects,
base::Time visit_time) override {}
+ virtual void NotifyURLsModified(const history::URLRows& rows) override {
droger 2014/11/12 17:56:59 Nit: remove virtual.
sdefresne 2014/11/13 09:12:01 Done.
+ modified_details_.reset(new history::URLRows(rows));
+ }
virtual void BroadcastNotifications(
int type,
scoped_ptr<HistoryDetails> details) override {
- switch (type) {
- case chrome::NOTIFICATION_HISTORY_URLS_DELETED: {
- scoped_ptr<URLsDeletedDetails> urls_deleted_details(
- static_cast<URLsDeletedDetails*>(details.release()));
- deleted_details_.reset(new history::URLRows(
- urls_deleted_details->rows));
- break;
- }
- case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED: {
- scoped_ptr<URLsModifiedDetails> urls_modified_details(
- static_cast<URLsModifiedDetails*>(details.release()));
- modified_details_.reset(new history::URLRows(
- urls_modified_details->changed_urls));
- break;
- }
- }
+ DCHECK(type == chrome::NOTIFICATION_HISTORY_URLS_DELETED);
+ scoped_ptr<URLsDeletedDetails> urls_deleted_details(
+ static_cast<URLsDeletedDetails*>(details.release()));
+ deleted_details_.reset(new history::URLRows(urls_deleted_details->rows));
}
virtual void DBLoaded() override {}

Powered by Google App Engine
This is Rietveld 408576698