Remove NOTIFICATION_HISTORY_URLS_MODIFIED

chrome/browser/history/android/android_provider_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/android/android_provider_backend.h"
 
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 62 matching lines @@
   virtual void SetInMemoryBackend(
       scoped_ptr<InMemoryHistoryBackend> backend) override {}
   virtual void NotifyAddVisit(const history::BriefVisitInfo& info) override {}
   virtual void NotifyFaviconChanged(const std::set<GURL>& url) override {
     favicon_changed_.reset(new std::set<GURL>(url.begin(), url.end()));
   }
   virtual void NotifyURLVisited(ui::PageTransition,
                                 const history::URLRow& row,
                                 const history::RedirectList& redirects,
                                 base::Time visit_time) override {}
+  virtual void NotifyURLsModified(const history::URLRows& rows) override {

[droger, 2014/11/12 17:56:59]

Nit: remove virtual.

[sdefresne, 2014/11/13 09:12:01]

Done.

+    modified_details_.reset(new history::URLRows(rows));
+  }
   virtual void BroadcastNotifications(
       int type,
       scoped_ptr<HistoryDetails> details) override {
-    switch (type) {
-      case chrome::NOTIFICATION_HISTORY_URLS_DELETED: {
-        scoped_ptr<URLsDeletedDetails> urls_deleted_details(
-            static_cast<URLsDeletedDetails*>(details.release()));
-        deleted_details_.reset(new history::URLRows(
-            urls_deleted_details->rows));
-        break;
-      }
-      case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED: {
-        scoped_ptr<URLsModifiedDetails> urls_modified_details(
-            static_cast<URLsModifiedDetails*>(details.release()));
-        modified_details_.reset(new history::URLRows(
-            urls_modified_details->changed_urls));
-        break;
-      }
-    }
+    DCHECK(type == chrome::NOTIFICATION_HISTORY_URLS_DELETED);
+    scoped_ptr<URLsDeletedDetails> urls_deleted_details(
+        static_cast<URLsDeletedDetails*>(details.release()));
+    deleted_details_.reset(new history::URLRows(urls_deleted_details->rows));
   }
   virtual void DBLoaded() override {}
 
   history::URLRows* deleted_details() const { return deleted_details_.get(); }
 
   history::URLRows* modified_details() const { return modified_details_.get(); }
 
   std::set<GURL>* favicon_changed() const { return favicon_changed_.get(); }
 
   void ResetDetails() {
@@ skipping 2039 matching lines @@
                                                  update_args, &update_count));
   // Verify notifications.
   EXPECT_FALSE(notifier_.deleted_details());
   ASSERT_TRUE(notifier_.modified_details());
   ASSERT_EQ(1u, notifier_.modified_details()->size());
   // No favicon will be updated as thumbnail database is missing.
   EXPECT_FALSE(notifier_.favicon_changed());
 }
 
 }  // namespace history