Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694693002: begin clean up for scalar is double option (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

begin clean up for scalar is double option BUG=skia: Committed: https://skia.googlesource.com/skia/+/bd1605905b1ce165e6b5891547c2b612358b47a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -118 lines) Patch
M include/core/SkScalar.h View 3 chunks +123 lines, -118 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694693002/1
6 years, 1 month ago (2014-10-31 02:41:23 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-31 02:41:23 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-10-31 08:41:28 UTC) #5
reed1
lgtm
6 years, 1 month ago (2014-10-31 12:18:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694693002/1
6 years, 1 month ago (2014-10-31 12:19:05 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 13:55:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as bd1605905b1ce165e6b5891547c2b612358b47a8

Powered by Google App Engine
This is Rietveld 408576698