Properly substitute variables that reference paths outside SRCDIR.

Properly substitute variables that reference paths outside SRCDIR.

Apply the same kind of trick added in r58 and use a define's base name if it
refers to a location outside SRCDIR; so far, GritNode::AssignFirstIds() would
parse a file name differently than _ReadFirstIdsFromFile() even though they
refer to the same entry.

BUG=
TEST=in Chromium, make BUILDTYPE=Release builddir_name=/outside/srcdir/out tracing_resources
R=joi@chromium.org

[Jói, 2013-11-11 22:27:05]

LGTM

Please confirm all unit tests (e.g. "grit.py unit") were passing for you, and I
can land this for you.

Cheers,
Jói

[Raphael Kubo da Costa (rakuco), 2013-11-11 23:39:23]

On 2013/11/11 22:27:05, Jói wrote:
> LGTM
> 
> Please confirm all unit tests (e.g. "grit.py unit") were passing for you, and
I
> can land this for you.

I did test that, and basically the same set of unit tests (testDictionaryPolicy,
testEmpty, testIntEnumPolicy, testIntPolicy, testMainPolicy,
testNonSupportedPolicy, testStringEnumPolicy and testStringPolicy, all in
grit.format.policy_templates.writers.plist_writer_unittest.PListWriterUnittest)
were failing here, with and without the patch, so at least this CL does not seem
to cause any regressions.

[Raphael Kubo da Costa (rakuco), 2013-11-12 11:14:46]

On 2013/11/11 23:39:23, Raphael Kubo da Costa (rakuco) wrote:
> I did test that, and basically the same set of unit tests
(testDictionaryPolicy,
> testEmpty, testIntEnumPolicy, testIntPolicy, testMainPolicy,
> testNonSupportedPolicy, testStringEnumPolicy and testStringPolicy, all in
>
grit.format.policy_templates.writers.plist_writer_unittest.PListWriterUnittest)
> were failing here, with and without the patch

(FWIW, bisecting shows those 8 test cases I mentioned were broke by r79)

[Raphael Kubo da Costa (rakuco), 2013-11-12 11:15:07]

broken, I mean.

[Jói, 2013-11-12 13:51:09]

On 2013/11/12 11:15:07, Raphael Kubo da Costa (rakuco) wrote:
> broken, I mean.

Closing this issue as it has been landed as r138 via
https://codereview.chromium.org/68163013/