Issue 21498. Fix for navigation from instance creation with type arguments.

pkg/analysis_server/test/analysis/notification_navigation_test.dart

Index: pkg/analysis_server/test/analysis/notification_navigation_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_navigation_test.dart b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
index 42c2d5a3776dd49734ad47014c58034f2ab005f7..11652be26782384c6059be0a9d83e0aaffeb8093 100644
--- a/pkg/analysis_server/test/analysis/notification_navigation_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
@@ -311,25 +311,33 @@ import 'dart:math';
 
   test_instanceCreation_implicit() {
     addTestFile('''
-class A {
+class A {}
+class B<T> {

[Paul Berry, 2014/11/03 20:35:13]

Rather than modifying these tests to use generic arguments, I'd recommend
leaving the tests as is and adding additional tests to verify that navigation
works correctly when template arguments are in use.

Otherwise we run the risk of regression the non-generic-argument case.

[scheglov, 2014/11/03 20:45:36]

Yes, I was not sure if it worth to keep non-generic tests or just change them.
It seems that we want to have both.
Done.

 }
 main() {
-  new A();
+  new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
-      findRegion(findOffset('new A'), 'new A'.length, true);
-      assertHasTarget('A {');
+      {
+        findRegion(findOffset('new B'), 'new'.length, true);
+        assertHasTarget('B<T> {');
+      }
+      {
+        findRegion(findOffset('A>();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
     });
   }
 
   test_instanceCreation_named() {
     addTestFile('''
-class A {
+class A {}
+class B<T> {
   A.named() {}
 }
 main() {
-  new A.named();
+  new B<A>.named();
 }
 ''');
     return prepareNavigation().then((_) {
@@ -338,32 +346,41 @@ main() {
         assertHasTarget('named() {}');
       }
       {
-        findRegion(findOffset('A.named();'), 'A'.length, true);
-        assertHasTarget('A {');
+        findRegion(findOffset('B<A>.named();'), 'B'.length, true);
+        assertHasTarget('B<T> {');
       }
       {
         findRegion(findOffset('.named();'), '.named'.length, true);
         assertHasTarget('named() {}');
       }
+      {
+        findRegion(findOffset('A>.named();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
     });
   }
 
   test_instanceCreation_unnamed() {
     addTestFile('''
-class A {
-  A() {}
+class A {}
+class B<T> {
+  B() {}
 }
 main() {
-  new A();
+  new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
       {
         findRegion(findOffset('new '), 'new'.length, true);
-        assertHasTarget('A() {}', 0);
+        assertHasTarget('B() {}', 0);
+      }
+      {
+        findRegion(findOffset('B<A>();'), 'B'.length, true);
+        assertHasTarget('B<T> {');
       }
       {
-        findRegion(findOffset('A();'), 'A'.length, true);
+        findRegion(findOffset('A>();'), 'A'.length, true);
         assertHasTarget('A {');
       }
     });