Issue 21498. Fix for navigation from instance creation with type arguments.

pkg/analysis_server/test/analysis/notification_navigation_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification.navigation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 293 matching lines @@
 }
 import 'dart:math';
 ''');
     return prepareNavigation().then((_) {
       assertHasRegionTarget('aaa);', 'aaa = 42');
     });
   }
 
   test_instanceCreation_implicit() {
     addTestFile('''
-class A {
+class A {}
+class B<T> {

[Paul Berry, 2014/11/03 20:35:13]

Rather than modifying these tests to use generic arguments, I'd recommend
leaving the tests as is and adding additional tests to verify that navigation
works correctly when template arguments are in use.

Otherwise we run the risk of regression the non-generic-argument case.

[scheglov, 2014/11/03 20:45:36]

Yes, I was not sure if it worth to keep non-generic tests or just change them.
It seems that we want to have both.
Done.

 }
 main() {
-  new A();
+  new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
-      findRegion(findOffset('new A'), 'new A'.length, true);
-      assertHasTarget('A {');
+      {
+        findRegion(findOffset('new B'), 'new'.length, true);
+        assertHasTarget('B<T> {');
+      }
+      {
+        findRegion(findOffset('A>();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
     });
   }
 
   test_instanceCreation_named() {
     addTestFile('''
-class A {
+class A {}
+class B<T> {
   A.named() {}
 }
 main() {
-  new A.named();
+  new B<A>.named();
 }
 ''');
     return prepareNavigation().then((_) {
       {
         findRegion(findOffset('new '), 'new'.length, true);
         assertHasTarget('named() {}');
       }
       {
-        findRegion(findOffset('A.named();'), 'A'.length, true);
-        assertHasTarget('A {');
+        findRegion(findOffset('B<A>.named();'), 'B'.length, true);
+        assertHasTarget('B<T> {');
       }
       {
         findRegion(findOffset('.named();'), '.named'.length, true);
         assertHasTarget('named() {}');
       }
+      {
+        findRegion(findOffset('A>.named();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
     });
   }
 
   test_instanceCreation_unnamed() {
     addTestFile('''
-class A {
-  A() {}
+class A {}
+class B<T> {
+  B() {}
 }
 main() {
-  new A();
+  new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
       {
         findRegion(findOffset('new '), 'new'.length, true);
-        assertHasTarget('A() {}', 0);
+        assertHasTarget('B() {}', 0);
       }
       {
-        findRegion(findOffset('A();'), 'A'.length, true);
+        findRegion(findOffset('B<A>();'), 'B'.length, true);
+        assertHasTarget('B<T> {');
+      }
+      {
+        findRegion(findOffset('A>();'), 'A'.length, true);
         assertHasTarget('A {');
       }
     });
   }
 
   test_multiplyDefinedElement() {
     addFile('$projectPath/bin/libA.dart', 'library A; int TEST = 1;');
     addFile('$projectPath/bin/libB.dart', 'library B; int TEST = 2;');
     addTestFile('''
 import 'libA.dart';
@@ skipping 175 matching lines @@
   test_type_void() {
     addTestFile('''
 void main() {
 }
 ''');
     return prepareNavigation().then((_) {
       assertNoRegionAt('void');
     });
   }
 }