Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 694363002: ui: Remove unused DialogModel::GetDialogLabel(). (Closed)

Created:
6 years, 1 month ago by sadrul
Modified:
6 years, 1 month ago
Reviewers:
kelvinp
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M ui/base/models/dialog_model.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sadrul
Thanks for noticing this is unused!
6 years, 1 month ago (2014-11-03 17:41:37 UTC) #2
kelvinp
Thank you for doing the change. lgtm. https://codereview.chromium.org/694363002/diff/1/ui/base/models/dialog_model.h File ui/base/models/dialog_model.h (left): https://codereview.chromium.org/694363002/diff/1/ui/base/models/dialog_model.h#oldcode15 ui/base/models/dialog_model.h:15: // to ...
6 years, 1 month ago (2014-11-03 20:35:45 UTC) #3
sadrul
https://codereview.chromium.org/694363002/diff/1/ui/base/models/dialog_model.h File ui/base/models/dialog_model.h (left): https://codereview.chromium.org/694363002/diff/1/ui/base/models/dialog_model.h#oldcode15 ui/base/models/dialog_model.h:15: // to the user (i.e. label, title), and the ...
6 years, 1 month ago (2014-11-03 22:42:22 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4948d9b8259a38b52c2da1a4acca539d4289785f Cr-Commit-Position: refs/heads/master@{#302514}
6 years, 1 month ago (2014-11-03 23:27:02 UTC) #5
sadrul
6 years, 1 month ago (2014-11-03 23:27:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4948d9b8259a38b52c2da1a4acca539d4289785f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698