Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 694313002: [turbofan] add RegisterConfiguration to decouple arch specific register layouts from compiler (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add RegisterConfiguration to decouple arch specific register layouts from compiler R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25097

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -137 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 1 2 3 10 chunks +55 lines, -19 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 10 chunks +45 lines, -30 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 2 chunks +5 lines, -15 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 15 chunks +27 lines, -39 lines 0 comments Download
A src/compiler/register-configuration.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A src/compiler/register-configuration.cc View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 5 chunks +28 lines, -25 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Benedikt Meurer
LGTM
6 years, 1 month ago (2014-11-04 09:13:18 UTC) #2
dcarney
6 years, 1 month ago (2014-11-04 09:22:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 25097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698