Add test for SelectDefaultBrowser and refactor implementation.

Add test for SelectDefaultBrowser and refactor implementation.

BUG=

Committed: https://crrev.com/ea143d9095da1a91b30bb1fcd0ebd965f0ba5f88
Cr-Commit-Position: refs/heads/master@{#302445}

[slamm, 2014-11-02 17:01:13]

Update comment. Shorter test code.

[slamm, 2014-11-02 17:02:02]

slamm@chromium.org changed reviewers:
+ nednguyen@google.com

[slamm, 2014-11-02 17:02:02]

A small clean-up.

[nednguyen, 2014-11-03 16:04:54]

lgtm

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
(left):

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:149:
return newest_browser
Yeah, why would we implement max() this way :-(

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py
(right):

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py:100:
class SelectDefaultBrowserTest(unittest.TestCase):
+1 for test.

[slamm, 2014-11-03 16:24:54]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-11-03 16:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694233002/20001

[slamm, 2014-11-03 16:25:55]

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py
(right):

https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py:100:
class SelectDefaultBrowserTest(unittest.TestCase):
On 2014/11/03 16:04:54, nednguyen wrote:
> +1 for test.

This worked nicely. I wrote the test and had it pass for the existing code.
Then, I refactored and made sure the test still worked.

[nednguyen, 2014-11-03 16:43:44]

On 2014/11/03 16:25:55, slamm wrote:
>
https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
> File
>
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py
> (right):
> 
>
https://codereview.chromium.org/694233002/diff/20001/tools/telemetry/telemetr...
>
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py:100:
> class SelectDefaultBrowserTest(unittest.TestCase):
> On 2014/11/03 16:04:54, nednguyen wrote:
> > +1 for test.
> 
> This worked nicely. I wrote the test and had it pass for the existing code.
> Then, I refactored and made sure the test still worked.

This sounds right :-)

[commit-bot: I haz the power, 2014-11-03 17:31:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-03 17:32:30]

Patchset 2 (id:??) landed as
https://crrev.com/ea143d9095da1a91b30bb1fcd0ebd965f0ba5f88
Cr-Commit-Position: refs/heads/master@{#302445}