tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py - Issue 694233002: Add test for SelectDefaultBrowser and refactor implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 694233002: Add test for SelectDefaultBrowser and refactor implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment. Shorter test code. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

index fea0b04f1fc6102691c06fd63856d23a9b931b52..effc1428db20200b2af13f461f4bd78e4f5598a7 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

@@ -141,13 +141,10 @@ class PossibleAndroidBrowser(possible_browser.PossibleBrowser):

def SelectDefaultBrowser(possible_browsers):

- local_builds_by_date = sorted(possible_browsers,

- key=lambda b: b.last_modification_time())

- if local_builds_by_date:

- newest_browser = local_builds_by_date[-1]

- return newest_browser

nednguyen 2014/11/03 16:04:54 Yeah, why would we implement max() this way :-(

- return None

+ """Return the newest possible browser."""

+ if not possible_browsers:

+ return None

+ return max(possible_browsers, key=lambda b: b.last_modification_time())

def CanFindAvailableBrowsers():