Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 694153002: DecoderStream: Check that no pending decode when flush is finished. (Closed)

Created:
6 years, 1 month ago by xhwang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DecoderStream: Check that no pending decode when flush is finished. This helps investigate the root cause of the BUG. BUG=427624 Committed: https://crrev.com/fbd8786db01a96cca590e7a11eb5c9999e71acce Cr-Commit-Position: refs/heads/master@{#302498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/filters/decoder_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
xhwang
A small CL which adds a check to help investigate the associated bug. PTAL
6 years, 1 month ago (2014-11-03 18:38:55 UTC) #2
sandersd (OOO until July 31)
lgtm
6 years, 1 month ago (2014-11-03 18:42:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694153002/1
6 years, 1 month ago (2014-11-03 19:47:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-03 19:47:35 UTC) #7
xhwang
dalecurtis: I need a committer to review my CL... Could you PTAL?
6 years, 1 month ago (2014-11-03 21:16:50 UTC) #9
DaleCurtis
lgtm
6 years, 1 month ago (2014-11-03 21:31:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694153002/1
6 years, 1 month ago (2014-11-03 21:32:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 22:18:16 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:19:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbd8786db01a96cca590e7a11eb5c9999e71acce
Cr-Commit-Position: refs/heads/master@{#302498}

Powered by Google App Engine
This is Rietveld 408576698