media/filters/decoder_stream.cc - Issue 694153002: DecoderStream: Check that no pending decode when flush is finished.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/decoder_stream.cc

Issue 694153002: DecoderStream: Check that no pending decode when flush is finished. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/decoder_stream.cc

diff --git a/media/filters/decoder_stream.cc b/media/filters/decoder_stream.cc

index 5a9861971326faadf83d109dfaeb1c263318cf83..b317a013d4108ccf1bd4b11d15d2907b727dd130 100644

--- a/media/filters/decoder_stream.cc

+++ b/media/filters/decoder_stream.cc

@@ -302,8 +302,10 @@ void DecoderStream<StreamType>::OnDecodeDone(int buffer_size,

TRACE_EVENT_ASYNC_END0("media", GetTraceString<StreamType>(), this);

- if (end_of_stream)

+ if (end_of_stream) {

+ DCHECK(!pending_decode_requests_);

decoding_eos_ = false;

+ }

if (state_ == STATE_ERROR) {

DCHECK(read_cb_.is_null());

« no previous file with comments | « no previous file | no next file » | no next file with comments »