Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 694093002: Add method to get filters for a bookmark in Enhanced bookmark bridge (Closed)

Created:
6 years, 1 month ago by Ian Wen
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add method to get filters for a bookmark in Enhanced bookmark bridge Per mock: https://beta-dot-folio.googleplex.com/chrome-ux/mocks/212-stars-iphone/20/phone#%2F05-detail-edit-bookmark.png%3Fc=hidden All tags/filters associated with a bookmark should be displayed in enhanced bookmark detail page. This CL introduced related APIs to jni bridge for UI to retrieve. BUG=NONE Committed: https://crrev.com/a52ec9a58e74ea25bd071bd6a48ae64ba28b86cd Cr-Commit-Position: refs/heads/master@{#302365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add javadoc #

Patch Set 3 : solve a partner bookmark case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 1 2 3 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 1 2 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Ian Wen
6 years, 1 month ago (2014-10-31 23:10:55 UTC) #2
Ted C
https://codereview.chromium.org/694093002/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc (right): https://codereview.chromium.org/694093002/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc#newcode97 chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:97: jint type) { type isn't used, but it probably ...
6 years, 1 month ago (2014-10-31 23:18:22 UTC) #3
Ian Wen
https://codereview.chromium.org/694093002/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc File chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc (right): https://codereview.chromium.org/694093002/diff/1/chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc#newcode97 chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:97: jint type) { On 2014/10/31 23:18:21, Ted C wrote: ...
6 years, 1 month ago (2014-10-31 23:46:23 UTC) #4
Ted C
lgtm
6 years, 1 month ago (2014-10-31 23:52:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694093002/40001
6 years, 1 month ago (2014-10-31 23:55:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-01 00:38:31 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:39:29 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a52ec9a58e74ea25bd071bd6a48ae64ba28b86cd
Cr-Commit-Position: refs/heads/master@{#302365}

Powered by Google App Engine
This is Rietveld 408576698