Add method to get filters for a bookmark in Enhanced bookmark bridge

chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h"
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
@@ skipping 72 matching lines @@
   DCHECK(enhanced_bookmark_model_->loaded());
   DCHECK_EQ(type, BookmarkType::BOOKMARK_TYPE_NORMAL);
 
   const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(
       enhanced_bookmark_model_->bookmark_model(), static_cast<int64>(id));
 
   enhanced_bookmark_model_->SetDescription(
       node, base::android::ConvertJavaStringToUTF8(env, description));
 }
 
+ScopedJavaLocalRef<jobjectArray> EnhancedBookmarksBridge::GetFiltersForBookmark(
+    JNIEnv* env,
+    jobject obj,
+    jlong id,
+    jint type) {

[Ted C, 2014/10/31 23:18:21]

type isn't used, but it probably should be.

If it's a BOOKMARK_TYPE_PARTNER then you either should be returning null or an
empty filter list.  Or you should be CHECKing that the type passed in is
TYPE_NORMAL because that is the only one where filters are applicable.

That and the id space for partner bookmark and regular can overlap so this could
also just return the wrong information if called on a partner bookmark.

[Ian Wen, 2014/10/31 23:46:23]

Done.

+  DCHECK(enhanced_bookmark_model_->loaded());
+  const BookmarkNode* node = bookmarks::GetBookmarkNodeByID(
+        enhanced_bookmark_model_->bookmark_model(), static_cast<int64>(id));
+  std::vector<std::string> filters =
+      cluster_service_->ClustersForBookmark(node);
+  return base::android::ToJavaArrayOfStrings(env, filters);
+}
+
 void EnhancedBookmarksBridge::GetBookmarksForFilter(JNIEnv* env,
                                                     jobject obj,
                                                     jstring j_filter,
                                                     jobject j_result_obj) {
   DCHECK(enhanced_bookmark_model_->loaded());
   const std::string title =
       base::android::ConvertJavaStringToUTF8(env, j_filter);
   const std::vector<const BookmarkNode*> bookmarks =
       cluster_service_->BookmarksForClusterNamed(title);
   for (const BookmarkNode* node : bookmarks) {
@@ skipping 139 matching lines @@
   return reinterpret_cast<jlong>(new EnhancedBookmarksBridge(
         env, obj, ProfileAndroid::FromProfileAndroid(j_profile)));
 }
 
 bool RegisterEnhancedBookmarksBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace enhanced_bookmarks