Issue 694063005: Introduce Diamond, a helper for building diamond-shaped control patterns.

Issue 694063005: Introduce Diamond, a helper for building diamond-shaped control patterns. (Closed)

Created:
6 years, 1 month ago by titzer

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Introduce Diamond, a helper for building diamond-shaped control patterns. R=mstarzinger@chromium.org, bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25110

Patch Set 2 : Add unit tests. #

Patch Set 3 : newline #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+391 lines, -243 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/change-lowering.cc	View	1	7 chunks	+23 lines, -61 lines	0 comments	Download
A	src/compiler/diamond.h	View		1 chunk	+85 lines, -0 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.cc	View		3 chunks	+7 lines, -19 lines	0 comments	Download
M	src/compiler/js-intrinsic-builder.cc	View		3 chunks	+17 lines, -34 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View		2 chunks	+3 lines, -14 lines	0 comments	Download
M	src/compiler/select-lowering.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1 2	9 chunks	+38 lines, -109 lines	0 comments	Download
M	test/cctest/compiler/test-control-reducer.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/unittests/compiler/diamond-unittest.cc	View	1	1 chunk	+161 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/node-test-utils.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/node-test-utils.cc	View	1	2 chunks	+47 lines, -0 lines	0 comments	Download
M	test/unittests/unittests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, yep, unit-tests would be nice. https://codereview.chromium.org/694063005/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/694063005/diff/1/src/compiler/simplified-lowering.cc#newcode1359 src/compiler/simplified-lowering.cc:1359: nit: One empty ...

6 years, 1 month ago (2014-11-04 13:09:38 UTC) #3

titzer

On 2014/11/04 13:09:38, Michael Starzinger wrote: > LGTM, yep, unit-tests would be nice. > Added ...

6 years, 1 month ago (2014-11-04 14:21:37 UTC) #4

titzer

6 years, 1 month ago (2014-11-04 14:37:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 25110 (presubmit successful).

Expand Messages | Collapse Messages