Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 693953002: Specify --ui-disable-partial-swap in the internal command Lines (Closed)

Created:
6 years, 1 month ago by GusFernandez
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, danakj, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Specify --ui-disable-partial-swap in the internal command Lines This works around a blue-screen bug with eglPostSubBuffer. BUG=429200 Committed: https://crrev.com/dbd2be26de239f58ca23b18e0e8f204cb6d7ba2e Cr-Commit-Position: refs/heads/master@{#302442}

Patch Set 1 #

Total comments: 2

Patch Set 2 : include cc/base/switches.h and modify DEPS #

Total comments: 2

Patch Set 3 : Change DEPS to depend on cc/base/switches.h specifically. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chromecast/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
GusFernandez
6 years, 1 month ago (2014-10-31 17:33:12 UTC) #2
lcwu1
https://codereview.chromium.org/693953002/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/693953002/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode39 chromecast/browser/cast_browser_main_parts.cc:39: const char kUIDisablePartialSwap[] = "ui-disable-partial-swap"; We shouldn't define our ...
6 years, 1 month ago (2014-10-31 17:37:31 UTC) #3
GusFernandez
6 years, 1 month ago (2014-11-01 01:42:51 UTC) #4
GusFernandez
6 years, 1 month ago (2014-11-01 01:43:12 UTC) #6
danakj
https://codereview.chromium.org/693953002/diff/20001/chromecast/browser/DEPS File chromecast/browser/DEPS (right): https://codereview.chromium.org/693953002/diff/20001/chromecast/browser/DEPS#newcode4 chromecast/browser/DEPS:4: "+cc/base", you could just deps on cc/base/switches.h?
6 years, 1 month ago (2014-11-03 15:53:22 UTC) #7
GusFernandez
https://codereview.chromium.org/693953002/diff/20001/chromecast/browser/DEPS File chromecast/browser/DEPS (right): https://codereview.chromium.org/693953002/diff/20001/chromecast/browser/DEPS#newcode4 chromecast/browser/DEPS:4: "+cc/base", On 2014/11/03 15:53:22, danakj wrote: > you could ...
6 years, 1 month ago (2014-11-03 16:34:25 UTC) #8
danakj
LGTM
6 years, 1 month ago (2014-11-03 16:35:27 UTC) #9
gunsch
lgtm
6 years, 1 month ago (2014-11-03 16:36:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693953002/40001
6 years, 1 month ago (2014-11-03 16:38:31 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-03 17:18:46 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 17:19:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dbd2be26de239f58ca23b18e0e8f204cb6d7ba2e
Cr-Commit-Position: refs/heads/master@{#302442}

Powered by Google App Engine
This is Rietveld 408576698