Specify --ui-disable-partial-swap in the internal command Lines

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
@@ skipping 17 matching lines @@
 #include "chromecast/crash/android/crash_handler.h"
 #include "components/crash/browser/crash_dump_manager_android.h"
 #include "net/android/network_change_notifier_factory_android.h"
 #endif  // defined(OS_ANDROID)
 
 namespace chromecast {
 namespace shell {
 
 namespace {
 
+// also defined in cc/base/switches.h but adding here due to checkdeps rules.
+const char kUIDisablePartialSwap[] = "ui-disable-partial-swap";

[lcwu1, 2014/10/31 17:37:31]

We shouldn't define our own switch string here (as the string defined in
cc/base/switches.cc could change). You will need to modify the DEPS file to
include cc/base and add one of the OWNERs from cc/base as a reviewer.

+
 struct DefaultCommandLineSwitch {
   const char* const switch_name;
   const char* const switch_value;
 };
 
 DefaultCommandLineSwitch g_default_switches[] = {
 #if defined(OS_ANDROID)
   { switches::kMediaDrmEnableNonCompositing, ""},
   { switches::kEnableOverlayFullscreenVideo, ""},
   { switches::kDisableInfobarForProtectedMediaIdentifier, ""},
   { switches::kDisableGestureRequirementForMediaPlayback, ""},
   { switches::kForceUseOverlayEmbeddedVideo, ""},
 #endif
   { switches::kDisableApplicationCache, "" },
   { switches::kDisablePlugins, "" },
   // Always enable HTMLMediaElement logs.
   { switches::kBlinkPlatformLogChannels, "Media"},
 #if defined(OS_LINUX) && defined(ARCH_CPU_X86_FAMILY)
   // This is needed for now to enable the egltest Ozone platform to work with
   // current Linux/NVidia OpenGL drivers.
   { switches::kIgnoreGpuBlacklist, ""},
+  // TODO(gusfernandez): This is needed to fix a bug with
+  // glPostSubBufferCHROMIUM (crbug: 429200)

[lcwu1, 2014/10/31 17:37:31]

The convention of specifying a crbug is crbug.com/429200.

+  { kUIDisablePartialSwap, ""},
 #endif
   { NULL, NULL },  // Termination
 };
 
 void AddDefaultCommandLineSwitches(CommandLine* command_line) {
   int i = 0;
   while (g_default_switches[i].switch_name != NULL) {
     command_line->AppendSwitchASCII(
         std::string(g_default_switches[i].switch_name),
         std::string(g_default_switches[i].switch_value));
@@ skipping 94 matching lines @@
   return true;
 }
 
 void CastBrowserMainParts::PostMainMessageLoopRun() {
   cast_browser_process_->cast_service()->Stop();
   cast_browser_process_.reset();
 }
 
 }  // namespace shell
 }  // namespace chromecast