Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/protobuf/README.chromium

Issue 693773003: Cleanup various includes and namespace references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/README.chromium
diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium
index b6ccf575c69534371db652c8f4d95ce2a3df43db..92391f6be3025def28bbda7e05139cfe5c30794b 100644
--- a/third_party/protobuf/README.chromium
+++ b/third_party/protobuf/README.chromium
@@ -33,3 +33,5 @@ Revision 523 was cherry-picked from upstream.
Revision 524 was cherry-picked from upstream.
Revision 573 was cherry-picked from upstream.
The `&file->options() != NULL &&` was removed from descriptor.cc
+References to `vector` were changed to `std::vector` in extension_set.h
+and unknown_field_set.h
Nico 2014/10/31 14:30:08 Did you change this upstream?
Fabrice (no longer in Chrome) 2014/10/31 15:45:24 I'm working on that part, just not sure if that sh
Nico 2014/10/31 16:10:03 I don't know either. agl@, pliard@, rmcilory@ have

Powered by Google App Engine
This is Rietveld 408576698