third_party/protobuf/README.chromium - Issue 693773003: Cleanup various includes and namespace references.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/README.chromium

Issue 693773003: Cleanup various includes and namespace references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/android/content_view_statics.cc ('K') | « net/quic/quic_sent_entropy_manager_test.cc ('k') | third_party/protobuf/src/google/protobuf/extension_set.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name: Protocol Buffers	1 Name: Protocol Buffers

2 Short Name: protobuf	2 Short Name: protobuf

3 URL: http://protobuf.googlecode.com/svn/trunk	3 URL: http://protobuf.googlecode.com/svn/trunk

4 License: BSD	4 License: BSD

5 License File: COPYING.txt	5 License File: COPYING.txt

6 Version: unknown	6 Version: unknown

7 Revision: r476	7 Revision: r476

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Local files (not taken from upstream):	10 Local files (not taken from upstream):

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 Revision 504 was cherry-picked from upstream.	27 Revision 504 was cherry-picked from upstream.

28 Revision 512 was cherry-picked from upstream.	28 Revision 512 was cherry-picked from upstream.

29 Revision 516 was cherry-picked from upstream.	29 Revision 516 was cherry-picked from upstream.

30 Revision 517 was cherry-picked from upstream.	30 Revision 517 was cherry-picked from upstream.

31 Revision 522 was cherry-picked from upstream.	31 Revision 522 was cherry-picked from upstream.

32 Revision 523 was cherry-picked from upstream.	32 Revision 523 was cherry-picked from upstream.

33 Revision 524 was cherry-picked from upstream.	33 Revision 524 was cherry-picked from upstream.

34 Revision 573 was cherry-picked from upstream.	34 Revision 573 was cherry-picked from upstream.

35 The `&file->options() != NULL &&` was removed from descriptor.cc	35 The `&file->options() != NULL &&` was removed from descriptor.cc

	36 References to `vector` were changed to `std::vector` in extension_set.h

	37 and unknown_field_set.h
	Nico 2014/10/31 14:30:08 Did you change this upstream? Did you change this upstream? Fabrice (no longer in Chrome) 2014/10/31 15:45:24 I'm working on that part, just not sure if that sh Show quoted text On 2014/10/31 14:30:08, Nico wrote: > Did you change this upstream? I'm working on that part, just not sure if that should be in github or elsewhere, but I did ping the protobuf folks about it. Nico 2014/10/31 16:10:03 I don't know either. agl@, pliard@, rmcilory@ have Show quoted text On 2014/10/31 15:45:24, Fabrice de Gans wrote: > On 2014/10/31 14:30:08, Nico wrote: > > Did you change this upstream? > > I'm working on that part, just not sure if that should be in github or > elsewhere, but I did ping the protobuf folks about it. I don't know either. agl@, pliard@, rmcilory@ have successfully upstreamed protobuf stuff (e.g. https://codereview.appspot.com/88800045/), so maybe ask them. (But yes, looks like they moved to github recently from what I can tell.)
OLD	NEW