Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 693583002: Expand quick menu buttons to fit their content (Closed)

Created:
6 years, 1 month ago by mohsen
Modified:
6 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expand quick menu buttons to fit their content Currently, touch selection quick menu buttons have the fixed size of 63x38. In some languages, texts need more space; so those buttons should be expanded to fit the whole text. BUG=417254 Committed: https://crrev.com/3f88ee90127eeedf0870a68cdfaf832be822e8b1 Cr-Commit-Position: refs/heads/master@{#302148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M ui/views/touchui/touch_editing_menu.cc View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mohsen
Can you please take a look...
6 years, 1 month ago (2014-10-30 17:14:56 UTC) #2
sadrul
lgtm
6 years, 1 month ago (2014-10-30 17:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693583002/1
6 years, 1 month ago (2014-10-30 18:14:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 20:30:31 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 20:31:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f88ee90127eeedf0870a68cdfaf832be822e8b1
Cr-Commit-Position: refs/heads/master@{#302148}

Powered by Google App Engine
This is Rietveld 408576698